과제 #37
Open
과제 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangheon-kim
reviewed
Apr 7, 2023
| <link rel="stylesheet" type="text/css" href="//db.onlinewebfonts.com/c/79e4dc6a81171b1523795cb6b2bc7b2f?family=Avenir+LT+Pro+55+Roman"/> | ||
| <link rel="stylesheet" href="./css/common.css"> | ||
| <link rel="stylesheet" href="./css/mobile.css"> | ||
| <link rel="stylesheet" media="all and (min-width:770px)" href="./css/pc.css"> |
| <meta property="og:url" content="https://www.socar.kr/"> | ||
|
|
||
| <link rel="icon" href="https://www.socar.kr/images/i-appicon.svg"> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/reset.min.css"> |
There was a problem hiding this comment.
보통 reset.css를 안에 내용도 확인안하고 사용해서 css를 overwrite이슈가 생기는 케이스를 여럿 봤어서 말씀드렸습니다
| <section class="main-visual scroll-spy"> | ||
| <header> | ||
| <a href="/"><img src="./images/logo-w.svg" alt="logo" id="logo"></a> | ||
| <div class="menubar"> |
|
|
||
| <!-- DOWNLOAD BANNER --> | ||
| <div class="download"> | ||
| <a href="javascript:void(0)"> |
There was a problem hiding this comment.
href에 그냥 #같은걸로 넣어주는게 훨씬 보기 좋을 것 같아요
|
|
||
| const spyEls = document.querySelectorAll('section.scroll-spy'); | ||
| spyEls.forEach(function(spyEl){ | ||
| new ScrollMagic |
There was a problem hiding this comment.
이렇게 쓰는게 맞는걸까요??
만약 이 기능이 해당 지점에 보이는걸 구현한거였다면, Intersection Observer를 알아보셔도 좋을 것 같아요
| this.timer = null; | ||
| this.counter(); | ||
| }; | ||
| numberCounter.prototype.counter = function() { |
There was a problem hiding this comment.
prototype 메서드를 쓰는 시도는 잘했지만,
numberCounter를 한번만 쓸거라면 차라리 클로저를 사용해보거나, 클래스를 사용해보는 방법도 생각해볼 수 있을 것 같아요
|
|
||
| // members 영역 숫자 올라가는 효과 | ||
|
|
||
| function numberCounter(target_frame, target_number) { |
There was a problem hiding this comment.
그리고 기본적으로 생성자 함수로 사용하실거라면 시맨틱상 맨 앞글자는 대문자가 원칙입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
쏘카 페이지를 클론 코딩했습니다.
원본 페이지 : https://www.socar.kr/
과제 페이지 : https://genuine-palmier-371aa9.netlify.app/